Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SourceLink] Ensure embedded source is shown with the right encoding #57350

Closed
davidwengier opened this issue Oct 24, 2021 · 1 comment · Fixed by #57683
Closed

[SourceLink] Ensure embedded source is shown with the right encoding #57350

davidwengier opened this issue Oct 24, 2021 · 1 comment · Fixed by #57683
Assignees
@davidwengier
Labels
Area-IDE Concept-Continuous Improvement IDE-Navigation Navigation and search Navigation-SourceLink Metadata as Source, SourceLink, Decompilation
Milestone
17.1

Comments

@davidwengier
Copy link
Contributor

Need to create the SourceText with the right encoding. See default-encoding and default-encoding compilation option stored in the PDB.

It would probably be better to store the compressed bytes (byte[]) in SourceDocument rather then constructing SourceText here. Then decompress and decode later when we actually need to create the SourceText (at that point we would also have the options decoded from compilation options).

Originally posted by @tmat in #57073 (comment)
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 24, 2021
@davidwengier davidwengier self-assigned this Oct 24, 2021
@davidwengier davidwengier mentioned this issue Oct 24, 2021
Merged
@davidwengier davidwengier changed the title Ensure embedded source is shown with the right encoding [SourceLink] Ensure embedded source is shown with the right encoding Oct 24, 2021
@davidwengier davidwengier mentioned this issue Oct 24, 2021
Open
11 tasks
@sharwell sharwell added Area-IDE IDE-Navigation Navigation and search Navigation-SourceLink Metadata as Source, SourceLink, Decompilation labels Oct 25, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 27, 2021
@jinujoseph jinujoseph added this to the 17.1 milestone Oct 27, 2021
@davidwengier davidwengier mentioned this issue Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
Area-IDE Concept-Continuous Improvement IDE-Navigation Navigation and search Navigation-SourceLink Metadata as Source, SourceLink, Decompilation
Projects
None yet
Milestone
17.1
Development

Successfully merging a pull request may close this issue.

[SourceLink] Use correct encoding for embedded text davidwengier/roslyn
3 participants
@davidwengier @sharwell @jinujoseph