Go To Definition from source information in PDBs #57073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods of getting source from metadata information, but "decompilation" is a concept that doesn't apply universally to all methods. Better to let features specify how they want data to be displayed, either full source or just signatures.
tmat
reviewed
Oct 22, 2021
src/Workspaces/Core/Portable/Workspace/Host/CompilationFactory/ICompilationFactoryService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Oct 22, 2021
src/Workspaces/CSharp/Portable/Workspace/LanguageServices/CSharpSyntaxTreeFactoryService.cs
Show resolved
Hide resolved
This was referenced Oct 24, 2021
This reverts commit 949a4e4.
…fected by the setting
|
FYI @jinujoseph I've updated this to point to dev17.1 as discussed |
tmat
reviewed
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55834
This is the MVP of Go To Def from document info stored in PDBs. It currently supports PDB files that are embedded, or next to the DLL files on disk. For source information it similarly supports source files that magically happen to be in the right spot on disk, or embedded source. I think the embedded PDB with embedded source puts the V in MVP here.
There is lots more work to come, including working with the debugger for proper source link support, and there is more cleanup and code sharing that can happen with the existing Metadata as Source provider that does decompilation, but in the interests of not making an already huge PR any bigger, those will be in follow ups. The refactoring from MetadataAsSourceFileService to DecompilationMetadatAsSourceFileProvider was just a move at this point. See the linked issue if you're curious.