Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SourceLink] Output window logging #57352

Closed
davidwengier opened this issue Oct 24, 2021 · 3 comments
Closed

[SourceLink] Output window logging #57352

davidwengier opened this issue Oct 24, 2021 · 3 comments
Assignees
Labels
Area-IDE Concept-Continuous Improvement IDE-Navigation Navigation and search Navigation-SourceLink Metadata as Source, SourceLink, Decompilation
Milestone

Comments

@davidwengier
Copy link
Contributor

It'd be useful to log to output window when we encounter errors, so that if something goes wrong the customer can inspect the output and see why it didn't work.

Originally posted by @tmat in #57073 (comment)


This should apply more broadly too, and we can log where we look for pdbs, source files, etc.

@sharwell
Copy link
Member

We have a Roslyn output window for this right?

@sharwell sharwell added Area-IDE IDE-Navigation Navigation and search Navigation-SourceLink Metadata as Source, SourceLink, Decompilation and removed Area-Infrastructure labels Oct 25, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 27, 2021
@jinujoseph jinujoseph added this to the 17.1 milestone Oct 27, 2021
@davidwengier
Copy link
Contributor Author

We have a Roslyn output window for this right?

Had a quick look at the roslyn output window we have is part of the logging infrastructure, and we'd want to keep this limited to Go To Def. I can experiment with enabling it only while GTD is running, but it might get noise from other things we don't want.

The aim for logging here is to be user facing to library authors diagnose why things might not be working.

@davidwengier
Copy link
Contributor Author

Fixed by #58209

@davidwengier davidwengier modified the milestones: 17.1, 17.1.P3 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement IDE-Navigation Navigation and search Navigation-SourceLink Metadata as Source, SourceLink, Decompilation
Projects
None yet
3 participants