Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS8063 - Improve wording #67525

Open
CyrusNajmabadi opened this issue Mar 28, 2023 Discussed in #67523 · 2 comments
Open

CS8063 - Improve wording #67525

CyrusNajmabadi opened this issue Mar 28, 2023 Discussed in #67523 · 2 comments
Labels
Area-Compilers Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings.
Milestone

Comments

@CyrusNajmabadi
Copy link
Member

Discussed in #67523

Originally posted by Korporal March 28, 2023
This has been bothering me for some time:

image

The message reads 'text' may be null here.

This is not really good English because 'may" means optional, permissible, something one could choose to allow, rather than undesirable, to be avoided, so this should really be changed to: 'text' might be null here.

This might be particularly confusing to non native English speakers too.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Mar 28, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@CyrusNajmabadi CyrusNajmabadi added Area-Compilers Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. labels Mar 28, 2023
@CyrusNajmabadi
Copy link
Member Author

Moved to issue. Wrt to the request here, i think either is fine, but 'may' seems more correct to me. This is discussing things in the present tense, not past or past-perfect tense, so 'may' is more appropriate. WRT probability, both are ok as we are not claiming anything about high/low probability (so either would be fine). Given that, i would personally keep as 'may'.

However, i'm fine seeing what others think wrt to grammar here as to if this can/should be improved.

@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Mar 31, 2023
@jcouv jcouv added this to the Backlog milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings.
Projects
None yet
Development

No branches or pull requests

2 participants