Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.AppContext to Roslyn.VisualStudio.InteractiveComponents #10667

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 18, 2016

No description provided.

@tmat
Copy link
Member Author

tmat commented Apr 18, 2016

@jasonmalinowski

@jasonmalinowski
Copy link
Member

As mentioned privately, move the reference add to something that's actually consuming the project. In theory the project.json here should be empty, since it's goal is just to collect dependencies of everything else.

@tmat
Copy link
Member Author

tmat commented Apr 18, 2016

Never mind. We don't actually need the facade. Removing it from the setup instead.

@tmat tmat closed this Apr 18, 2016
@tmat tmat reopened this Apr 18, 2016
@tmat tmat changed the title Add System.AppContext to Roslyn.VisualStudio.InteractiveComponents Remove System.AppContext to Roslyn.VisualStudio.InteractiveComponents Apr 18, 2016
@jasonmalinowski
Copy link
Member

👍

@tmat
Copy link
Member Author

tmat commented Apr 19, 2016

Eta failed due to #10527

@tmat tmat closed this Apr 19, 2016
@tmat tmat reopened this Apr 19, 2016
@tmat tmat merged commit 437d451 into dotnet:future Apr 19, 2016
@tmat tmat deleted the AppContext branch April 19, 2016 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants