Populate switch tweaks

[CyrusNajmabadi]

This change tweaks 'Populate Switch' to provide from 1-3 fixes to the user depending on the state of the switch. The potential fixes provided are:

Add missing cases.
Add missing 'default' case
Add both

[Hosch250]

Why did you PR to Future instead of Master? My PR was merged into Master, so shouldn't it be corrected there and be auto-PR'ed to Future?

[CyrusNajmabadi]

Because IOperatoin has been disabled in Master :)

[mattwar]

@dotnet-bot retest prtest/lin/dbg/unit32 please
// Previous failure: http://dotnet-ci.cloudapp.net/job/roslyn_prtest_lin_dbg_unit32/6507/
// Retest reason:

[Hosch250]

OK. I hope this gets worked in before it is released: it is quite an improvement over my first version.

[CyrusNajmabadi]

We're discussing what to do. :)

[CyrusNajmabadi]

@dotnet/roslyn-ide please review.

[CyrusNajmabadi]

We've decided we're going to do all the work here out of 'future'. We'll be disabling this in master and shipping this out of future (with IOperations) instead. Thanks!

[rchande]

👍

[CyrusNajmabadi]

tagging @dotnet/roslyn-ide For signoff.

[CyrusNajmabadi]

test vsi please

[jmarolf]

👍

[CyrusNajmabadi]

retest this please

[CyrusNajmabadi]

retest vsi please

[DustinCampbell]

adding @mattwar for SyntaxGenerator API additions

[DustinCampbell]

change looks righteous though 👍

[mattwar]

what are the missing tokens for?

[CyrusNajmabadi]

So that if you add switch sections to switch (foo) you get switch (foo) { case ... } not switch (foo) case ...

This enables someone to easily just do: switch (foo)<ctrl-dot><add missing cases> and have a fully formed switch they can use.

[mattwar]

in case you are operating on a code fragment? I see, since you've only just typed the first part and you want to auto generate the cases? Couldn't you just add the token directly without the rewriter?

[Hosch250]

I haven't tried this, but you could probably just do CSharpSyntaxFactory.Block({newNodesFromGenerator}) instead of modifying the generator.

[CyrusNajmabadi]

Couldn't you just add the token directly without the rewriter?

I could... but then i'd have to write logic specifically to handle the open and close tokens being missing. I just decided i would write the helper once and then would have it whenver i needed it.

[CyrusNajmabadi]

CSharpSyntaxFactory.Block({newNodesFromGenerator})

'Block' won't generate the write type of node for a switch statement unfortunately.

[CyrusNajmabadi]

test vsi please

[CyrusNajmabadi]

test vsi please