Add options to enable/disable nuget search. #11023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @dotnet/roslyn-ide |
|
test vsi please |
|
@dotnet-bot retest prtest/win/vsi/p2 please |
| using Moq; | ||
| using Roslyn.Test.Utilities; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Diagnostics.AddUsing | ||
| { | ||
| using FixProviderData = Tuple<IPackageInstallerService, IPackageSearchService>; | ||
| using CodeAnalysis.Shared.Options; |
There was a problem hiding this comment.
Nit: Why are these inside the namespace?
| @@ -8,6 +8,7 @@ | |||
| using Microsoft.CodeAnalysis.CodeActions; | |||
| using Microsoft.CodeAnalysis.Host; | |||
| using Microsoft.CodeAnalysis.Packaging; | |||
| using Microsoft.CodeAnalysis.SymbolSearch; | |||
There was a problem hiding this comment.
Types moved out of the packaging namespace into this new namespace.
| @@ -10,6 +9,8 @@ | |||
| using Microsoft.CodeAnalysis.Packaging; | |||
| using Microsoft.CodeAnalysis.Shared.Extensions; | |||
| using Roslyn.Utilities; | |||
| using Microsoft.CodeAnalysis.Shared.Options; | |||
| using Microsoft.CodeAnalysis.SymbolSearch; | |||
|
👍 |
| [ExportOptionProvider, Shared] | ||
| internal class AddImportOptionsProvider : IOptionProvider | ||
| { | ||
| private readonly IEnumerable<IOption> _options = ImmutableArray.Create<IOption>( |
There was a problem hiding this comment.
I'm sad if the generic method needs <IOption> 😄
| <value>Import Directives</value> | ||
| </data> | ||
| <data name="Option_Suggest_imports_for_types_in_NuGet_packages" xml:space="preserve"> | ||
| <value>Suggest imports for types in NuGet packages</value> |
|
Test vsi please |
|
👍 |
|
retest prtest/win/vsi/p2 please |
|
retest prtest/win/vsi/p3 please |
|
test prtest/win/vsi/p2 please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.