Allow generic type parameters to be the same type in method generation #11151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-ide |
jmarolf
force-pushed
the
generate-method-crash-in-generics
branch
from
34fb562
to
114844e
Compare
| @@ -64,10 +64,10 @@ public static IMethodSymbol RenameTypeParameters(this IMethodSymbol method, ILis | |||
| var updatedTypeParameters = RenameTypeParameters( | |||
| method.TypeParameters, newNames, typeGenerator); | |||
|
|
|||
| var mapping = new Dictionary<ITypeSymbol, ITypeSymbol>(); | |||
| var mapping = new List<KeyValuePair<ITypeSymbol, ITypeSymbol>>(); | |||
There was a problem hiding this comment.
Use ValueTuple instead of KVP.
|
Easier solution: keep using a dictionary, just use the |
jmarolf
force-pushed
the
generate-method-crash-in-generics
branch
from
114844e
to
c88f751
Compare
Previouly we assumed that the type parameters in a method would not be of the same TypeSymbol when generating a method and put them in a dictionary. This causes exceptions when attempting to add to the dictionary and the TypeSymbol is already added as a key. Now we use a list of instead of a dictionary. Fixes dotnet#10004
jmarolf
force-pushed
the
generate-method-crash-in-generics
branch
from
c88f751
to
63e7ce7
Compare
|
@CyrusNajmabadi review plz |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previouly we assumed that the type parameters in a method would not be of
the same
TypeSymbolwhen generating a method and put them in a dictionary.This causes exceptions when attempting to add to the dictionary and the
TypeSymbolis already added as a key. Now we use a list of instead of adictionary.
Fixes #10004