Added traits attributes to the generators tests #11182
Conversation
Some CR feedback tidyup.
|
@cston @jcouv @jaredpar @AlekseyTs - CR feedback on previous change. Primarily adding CompilerTrait attribute |
| using Roslyn.Test.Utilities; | ||
| using System.Linq; | ||
| using System.Threading; |
There was a problem hiding this comment.
I thought we want System usings to be on top (if the VS option is properly set).
There was a problem hiding this comment.
I personally do not care whichever way usings are sorted
I just use the built-in "Sort Using" feature.
If there is a discussion about this, I'd strongly support following the default behavior :-)
There was a problem hiding this comment.
I don't believe we should care about the order at all.
|
LGTM |
| { | ||
| return CreateCompilationWithMscorlib(text, options: options, parseOptions: TestOptions.Regular.WithReplaceFeature()); | ||
| } | ||
|
|
||
| [CompilerTrait(CompilerFeature.SourceGenerators)] |
There was a problem hiding this comment.
I thought we could simply mark the type and avoid the need to mark individual tests within it.
There was a problem hiding this comment.
Yes that's the much simpler approach. We should do that.
|
LGTM, but consider marking the types as well (or instead) so that new tests wouldn't have to be marked. |
|
I think I have addressed all concerns and concerns were minor. |
Added traits attributes to the generators tests.
Some CR feedback tidying up.