Add more tests for recently-fixed dynamic bugs #11341
Conversation
| } | ||
| "; | ||
|
|
||
| // TODO: Figure out if we want this error or not. |
There was a problem hiding this comment.
It looks like this is a breaking change vs native -- native used to let this pass through.
We also have a policy on no bare TODOs: all TODOs must have issues filed.
|
@khyperia We need to expedite the decision on whether we want to keep the break or not. |
|
@AlekseyTs I'll close this issue with the compat team tomorrow. So far we have tentative approval and no objections. |
|
I've updated this assuming we decided to keep the breaking change, but I believe a final decision hasn't been reached yet (still tentative, as Neal said). Avoid merging until that's final, should be later today (assuming the decision doesn't change). Rebased to grab |
|
@khyperia We have approval from the compat council. |
👍
gafter
added
4 - In Review
| @@ -6,3 +6,6 @@ Each entry should include a short description of the break, followed by either a | |||
| 1. In some cases, due to a bug in the native compiler, programs with pointers to structs with one or more | |||
| type parameters compiled without error. All such programs should now produce errors in Roslyn. See | |||
| [#5712](https://github.com/dotnet/roslyn/issues/5712) for examples and details. | |||
| 2. When calling a method group with only instance methods in a static context with dynamic arguments, the | |||
There was a problem hiding this comment.
As it says at the top, please link the bug. (The full details part is actually just for instances where we know there's a break but don't have an issue, or the issue was internal. I'll add that above.)
|
👍 |
More tests for issues #9945 and #10463 as discussed in PRs #11219 and #11256 as well as in-person.
Ping @dotnet/roslyn-compiler for review.