Generalize dynamic static-only restriction to include field initializers #11256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2016 15:31
|
|
LGTM
|
|
|
LGTM |
| { | ||
| object a = Test((dynamic)2); | ||
|
|
||
| static object Test(object obj) => obj; |
There was a problem hiding this comment.
Could you please add a test with an instance method?
There was a problem hiding this comment.
It looks like there is a breaking change in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10463
Native compiler handled all cases, Roslyn generated invalid IL when using dynamic in a field initializer. Roslyn does already handle dynamic in a constructor initializer, like the following case:
This PR simply hooks into that logic and extends it to field initializers as well (which also run before the base constructor call).
Ping @dotnet/roslyn-compiler for review.