Make debug command line arguments parsing consistent on Unix platforms #17106
Conversation
|
@tmat This purports to fix a bug you recently introduced. /cc @dotnet/roslyn-compiler This probably doesn't belong in the |
|
I'd like to see this to be in next RC so we don't have to patch msbuild to work with csc on non-windows platforms |
Unfortunately this won't meet the bar for RC. It will have to go into the 15.1 release instead. As @gafter pointed out though this likely need to be merged into a different branch than this one. The infra for this is being worked out today / tomorrow. Will report back once we have everything setup. |
| @@ -60,7 +60,7 @@ public new CSharpCommandLineArguments Parse(IEnumerable<string> args, string bas | |||
| bool concurrentBuild = true; | |||
| bool deterministic = false; // TODO(5431): Enable deterministic mode by default | |||
| bool emitPdb = false; | |||
| DebugInformationFormat debugInformationFormat = DebugInformationFormat.Pdb; | |||
| DebugInformationFormat debugInformationFormat = PathUtilities.IsUnixLikePlatform ? DebugInformationFormat.PortablePdb : DebugInformationFormat.Pdb; | |||
There was a problem hiding this comment.
Can we get some tests for this?
| @@ -92,7 +92,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic | |||
| Dim concurrentBuild As Boolean = True | |||
| Dim deterministic As Boolean = False | |||
| Dim emitPdb As Boolean | |||
| Dim debugInformationFormat As DebugInformationFormat = DebugInformationFormat.Pdb | |||
| Dim debugInformationFormat As DebugInformationFormat = If(PathUtilities.IsUnixLikePlatform, DebugInformationFormat.PortablePdb, DebugInformationFormat.Pdb) | |||
There was a problem hiding this comment.
Can we get some tests for this?
|
Agree with @jaredpar on testing. |
|
There is a test for this change already which is failing (part of d837ae8) but because you are running tests on windows only nothing is red |
|
@marek-safar ah I see. Yeah right now we're only running the parser tests on Windows. The remainder of the tests are getting moved over in the next month or so. |
|
@jaredpar could you merge it |
|
@marek-safar need one more sign off for merge. @tmat can you sign off on this? |
|
👍 |
Customer scenario
d837ae8 changed default debug format on non-windows platforms but only for explicitly passed
fullorpdbonlyarguments which makes it inconsistent with windows and documentation.Without this change
csc /debugorcsc /debug+still fail witherror CS0041: Unexpected error writing debug information -- 'Windows PDB writer is not available -- could not find Microsoft.DiaSymReader.Native.amd64.dll'