Implemented automatic regeneration of syntax, error facts and bound nodes #19400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
When you edit any of the xml files that are used to generate sources, they are not picked up automatically like they used to.
Bugs this fixes:
#19399
Workarounds, if any
You could use a batch file, but it's a pain when you have to build twice because you forgot to run it.
Risk
The commands are flakier than I wanted because of dotnet/project-system#1569
Performance impact
No impact on the compiler, the build time of CSharpCodeAnalysis and its VB cousin is extended by two-three seconds.
Is this a regression from a previous update?
Root cause analysis:
I don't know. Someone changed the generators.
How was the bug found?
Contributor pain