Show files in Solution Explorer #20842
Conversation
| @@ -498,4 +498,13 @@ | |||
| <AdditionalFiles Include="@(PublicAPI)" /> | |||
| </ItemGroup> | |||
|
|
|||
| <!-- CPS doesn't show these items by default, but we want to show them. --> | |||
There was a problem hiding this comment.
Aren't these bugs that should be fixed elsewhere?
There was a problem hiding this comment.
Well technically CPS does add these files as <None> items, but we explicitly disabled that feature. I imagine that this will be addressed by dotnet/project-system#113.
There was a problem hiding this comment.
Which one of the chanes disabled displaying that?
There was a problem hiding this comment.
@jaredpar <EnableDefaultNoneItems>False</EnableDefaultNoneItems>
There was a problem hiding this comment.
EnableDefaultNoneItems=false is a good thing and shouldn't be disabled. Basically the SDK picks up any file in a given directory and adds it as a None item. This causes some weird issues in the IDE like dotnet/sdk#1157. Basically we shouldn't have done that in the SDK and we should set EnableNoneItems=false by default in the SDK if it wasn't a breaking change.
This change here of adding None globs for the files that we want to show explicitly is preferable.
Note though that once we have WPF support, we would Page items so that line may become unnecessary.
My Projectfolders in VB, which I wasn't sure should be excluded)