-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show files in Solution Explorer #20842
Conversation
@@ -498,4 +498,13 @@ | |||
<AdditionalFiles Include="@(PublicAPI)" /> | |||
</ItemGroup> | |||
|
|||
<!-- CPS doesn't show these items by default, but we want to show them. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these bugs that should be fixed elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well technically CPS does add these files as <None>
items, but we explicitly disabled that feature. I imagine that this will be addressed by dotnet/project-system#113.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one of the chanes disabled displaying that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaredpar <EnableDefaultNoneItems>False</EnableDefaultNoneItems>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➡️ Filed #20863
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EnableDefaultNoneItems=false is a good thing and shouldn't be disabled. Basically the SDK picks up any file in a given directory and adds it as a None item. This causes some weird issues in the IDE like dotnet/sdk#1157. Basically we shouldn't have done that in the SDK and we should set EnableNoneItems=false by default in the SDK if it wasn't a breaking change.
This change here of adding None globs for the files that we want to show explicitly is preferable.
Note though that once we have WPF support, we would Page items so that line may become unnecessary.
My Project
folders in VB, which I wasn't sure should be excluded)