Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS sign debugger binaries #21468

Merged
merged 1 commit into from
Aug 15, 2017
Merged

OSS sign debugger binaries #21468

merged 1 commit into from
Aug 15, 2017

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 12, 2017

No description provided.

@tmat
Copy link
Member Author

tmat commented Aug 12, 2017

@jaredpar

@tmat
Copy link
Member Author

tmat commented Aug 13, 2017 •
edited
Loading

Test failures: #21110, #20991

@tmat
Copy link
Member Author

tmat commented Aug 13, 2017

test windows_debug_unit64_prtest please

@tmat
Copy link
Member Author

tmat commented Aug 13, 2017

test windows_release_vs-integration_prtest please

jaredpar
jaredpar reviewed Aug 14, 2017
View reviewed changes
src/Tools/GenerateSdkPackages/make-all.ps1
Create-Directory $debuggerRefDir
Create-Directory $debuggerImplDir

Copy-Item -re -fo (Join-Path $dropPath "..\..\Debugger\ReferenceDLL\*") $debuggerRefDir
Copy-Item -re -fo (Join-Path $dropPath "..\..\Debugger\IDE\Microsoft.VisualStudio.Debugger.Engine.dll") $debuggerImplDir
Copy-Item -re -fo (Join-Path $dropPath "Microsoft.VisualStudio.Debugger.Metadata.dll") $debuggerImplDir

Get-ChildItem $debuggerDir -Recurse -File | ForEach-Object { & $fakeSign -f $_.FullName }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did this become necessary again? The debugger should be producing signed binaries to that location. Did they stop doing that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it. Perhaps it depends on the branch? vsucorediag has them delay/test signed. @gregg-miskelly @caslan

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All bits produced in a VS repo behave the same - only a few labs will produce real signed bits, and some of those don't do it with every build. When we switch to pulling bits from the Concord repo this problem should go away.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay that makes sense. I removed that line originally because I started pulling from only branches that had signed binaries.

@tmat tmat merged commit 1bb513e into dotnet:master Aug 15, 2017
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 17, 2017
@333fred
Merge remote-tracking branch 'dotnet/features/ioperation' into ilabel…
443d458 
…statement-refactor

* dotnet/features/ioperation: (71 commits)
  Rename parameters.
  renamed methods.
  Rename method.
  Move integration test machines to 15.3 RTM (dotnet#21535)
  Update comment
  Fixed unintentional capitalization change, corrected grammar.
  Do a better job with leading trivia on types when moving types to a new file.
  Remove Release subdir from template output path (dotnet#21482)
  Fix bug in 'this' optimization for classes (dotnet#21510)
  Add test.
  Improve find-refs behavior when the user invokes it with a symbol selected.
  Fix regression in VB attribute classification.
  Fixed unintentional capitalization change.
  fix merge issues
  OSS sign debugger binaries. (dotnet#21468)
  More test fixes.
  Fixed misgenerated tests.
  Use default tuple fields in conversion since fields from inferred names are marked not usable in C#7
  Add note that while we could implement dynamic invocations, we chose not to
  Refactor comments in local function binder
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 17, 2017
@333fred
Merge remote-tracking branch 'dotnet/features/ioperation' into remove…
1eb79ff 
…-literal-text

* dotnet/features/ioperation: (77 commits)
  Refactor variable names.
  Rename parameters.
  renamed methods.
  Rename method.
  Move integration test machines to 15.3 RTM (dotnet#21535)
  Update comment
  Fixed unintentional capitalization change, corrected grammar.
  Do a better job with leading trivia on types when moving types to a new file.
  Fixed unintentional capitalization change.
  Remove Release subdir from template output path (dotnet#21482)
  Fix bug in 'this' optimization for classes (dotnet#21510)
  Add test.
  Improve find-refs behavior when the user invokes it with a symbol selected.
  Fix regression in VB attribute classification.
  Fixed unintentional capitalization change.
  fix merge issues
  OSS sign debugger binaries. (dotnet#21468)
  More test fixes.
  Fixed misgenerated tests.
  Use default tuple fields in conversion since fields from inferred names are marked not usable in C#7
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@gregg-miskelly gregg-miskelly gregg-miskelly approved these changes

Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tmat @jaredpar @gregg-miskelly @dnfclas