Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default tuple fields in conversion since fields from inferred names are marked not usable in C#7 #21520

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

cston
Copy link
Member

@cston cston commented Aug 15, 2017

Customer scenario

Create an unnamed tuple with an implicit conversion to a named tuple in C#7.1 with the default language version (C#7.0).

Bugs this fixes:

#21518

Workarounds, if any

Use explicit tuple element names or an explicit conversion.

Risk

Low.

Performance impact

None.

Is this a regression from a previous update?

Regression resulting from inferred tuple names.

How was the bug found?

Customer reported.

@cston
Copy link
Member Author

cston commented Aug 15, 2017

@dotnet/roslyn-compiler please review.

Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants