Use default tuple fields in conversion since fields from inferred names are marked not usable in C#7 #21553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… names are marked not usable in C#7
are marked not usable in C#7
|
test mac please |
|
@binki, thanks for reporting your example. Yes, this change fixes that issue. |
|
The fix went into 15.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Create an unnamed tuple with an implicit conversion to a named tuple in C#7.1 with the default language version (C#7.0). Or use deconstruction assignment where the RHS contains two or more tuple literals with different types and inferred names.
Bugs this fixes:
#21028
#21518
Workarounds, if any
Rewrite the expression to use explicit conversions or explicit tuple element names.
Risk
Low
Performance impact
None
Is this a regression from a previous update?
Regression from inferred tuple names.
How was the bug found?
Customer reported