Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tests to cover test plans #19216 and #20127 #22284

Merged
merged 4 commits into from
Sep 28, 2017
Merged

Create tests to cover test plans #19216 and #20127 #22284

merged 4 commits into from
Sep 28, 2017

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Sep 22, 2017 •
edited
Loading

@OmarTawfik OmarTawfik added Area-Compilers PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. Test Test failures in roslyn-CI labels Sep 22, 2017
@OmarTawfik OmarTawfik added this to the 15.5 milestone Sep 22, 2017
@OmarTawfik OmarTawfik requested review from VSadov, gafter, jcouv and a team September 22, 2017 04:22
@OmarTawfik OmarTawfik removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Sep 22, 2017
@OmarTawfik
Copy link
Contributor Author

cc @VSadov @gafter @jcouv @dotnet/roslyn-compiler

@OmarTawfik OmarTawfik mentioned this pull request Sep 22, 2017
Closed
@OmarTawfik
Copy link
Contributor Author

@VSadov @gafter @jcouv @dotnet/roslyn-compiler ping

VSadov
VSadov approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jcouv
jcouv approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and approved for 15.5

@OmarTawfik OmarTawfik merged commit f99832a into dotnet:master Sep 28, 2017
@OmarTawfik OmarTawfik deleted the test-plan-additional-tests branch September 28, 2017 21:01
333fred added a commit to 333fred/roslyn that referenced this pull request Sep 29, 2017
@333fred
Merge remote-tracking branch 'dotnet/master' into delegate-creation
3460d12 
* dotnet/master:
  Report binding error for typed LINQ query on a type expression (dotnet#22412)
  clean up
  more refactoring
  Fixed tests
  fix test after rebase
  one more test
  CR feedback
  Allow taking unmanaged/pinned addresses of readonly variables.
  Fix typo in INotifyCompletion API in doc (dotnet#22417)
  Fix serialization of attribute data to account for named params argument (dotnet#22231)
  Create tests to cover test plans dotnet#19216 and dotnet#20127 (dotnet#22284)
  Checked uses of RefKind.RefReadOnly
  String rename
  Check for null before registering incremental analyzer in work coordinator.
  clean up
  Create tests to cover test plans dotnet#19216 and dotnet#20127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VSadov VSadov VSadov approved these changes

@jcouv jcouv jcouv approved these changes

@gafter gafter Awaiting requested review from gafter

Assignees
No one assigned
Labels
Approved to merge Area-Compilers cla-already-signed Test Test failures in roslyn-CI
Projects
None yet
Milestone
15.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OmarTawfik @VSadov @jcouv @dnfclas