Report binding error for typed LINQ query on a type expression #22412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cston
approved these changes
Sep 29, 2017
AlekseyTs
reviewed
Sep 29, 2017
| { | ||
| // Could not find an implementation of the query pattern for source type '{0}'. '{1}' not found. | ||
| diagnostics.Add(ErrorCode.ERR_QueryNoProvider, node.Location, receiverOpt.Type, memberSymbol.Name); | ||
| if (receiverOpt?.Kind == BoundKind.QueryClause) |
There was a problem hiding this comment.
? [](start = 39, length = 1)
It looks safe dropping the conditional aspect of this access. #Closed
AlekseyTs
reviewed
Sep 29, 2017
| @@ -2523,5 +2523,51 @@ static void Main() | |||
| Diagnostic(ErrorCode.ERR_LocalIllegallyOverrides, "a").WithArguments("a").WithLocation(10, 43) | |||
| ); | |||
| } | |||
|
|
|||
| [Fact, WorkItem(12052, "https://github.com/dotnet/roslyn/issues/12052")] | |||
There was a problem hiding this comment.
12052 [](start = 24, length = 5)
Should this be 21484? #Closed
|
Done with review pass (iteration 1). #Closed |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Sep 29, 2017
* dotnet/master: Report binding error for typed LINQ query on a type expression (dotnet#22412) clean up more refactoring Fixed tests fix test after rebase one more test CR feedback Allow taking unmanaged/pinned addresses of readonly variables. Fix typo in INotifyCompletion API in doc (dotnet#22417) Fix serialization of attribute data to account for named params argument (dotnet#22231) Create tests to cover test plans dotnet#19216 and dotnet#20127 (dotnet#22284) Checked uses of RefKind.RefReadOnly String rename Check for null before registering incremental analyzer in work coordinator. clean up Create tests to cover test plans dotnet#19216 and dotnet#20127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Use a type as the collection in a LINQ query with a typed variable (
from object x in IEnumerable ...). The compiler should produce an error, but instead it fails when emitting.Bugs this fixes:
Fixes #21484
Details:
When a LINQ query specifies a type (
from object x in y), we will make an invocation for it:y.Cast<object>(). WhenyisIEnumerable, we find an extension methodSystem.Linq.Enumerable.Cast<object>(this IEnumerable).After we find it, this PR adds a check and reports a diagnostic, because that is trying to invoke an extension method with a type as its receiver (but an instance is required).
Note, the error is reported from another branch of the same method (
MemberGroupFinalValidationAccessibilityChecks) in this scenario:Workarounds, if any
Fix your code. But the compiler doesn't provide diagnostics pointing to the source of the error :-(
Risk
Performance impact
Low. Adding one more check during binding of queries.
Thanks @AlekseyTs for the help narrowing down a low-risk fix :-)
Is this a regression from a previous update?
No.
How was the bug found?
Reported by customer.
@dotnet/roslyn-compiler for review. Thanks