Report CS0675 warning for compound assignment operator. #2416
Conversation
|
LGTM |
| @@ -388,7 +399,7 @@ private void CheckVacuousComparisons(BoundBinaryOperator tree, ConstantValue con | |||
| } | |||
| } | |||
|
|
|||
| private void CheckOr(BoundBinaryOperator node) | |||
There was a problem hiding this comment.
IMHO the name of this method is a bit misleading. Can we rename it to CheckIfOr or add a comment specifying that it only performs checks in the case that it is an Or style operator?
There was a problem hiding this comment.
@jaredpar How does "CheckForBitwiseOrSignExtend" sound?
There was a problem hiding this comment.
SGTM
Overall change LGTM as well.
JaredPar from a phone
http://blog.paranoidcoding.com/
From: AlekseyTs notifications@github.com
Sent: Friday, May 1, 2015 10:48:31 AM
To: dotnet/roslyn
Cc: Jared Parsons
Subject: Re: [roslyn] Report CS0675 warning for compound assignment operator. (#2416)
In src/Compilers/CSharp/Portable/Lowering/DiagnosticsPass_Warnings.cshttps://github.com//pull/2416#discussion_r29518866:
@@ -388,7 +399,7 @@ private void CheckVacuousComparisons(BoundBinaryOperator tree, ConstantValue con
}
}
private void CheckOr(BoundBinaryOperator node)
@jaredparhttps://github.com/jaredpar How does "CheckForBitwiseOrSignExtend" sound?
Reply to this email directly or view it on GitHubhttps://github.com//pull/2416/files#r29518866.
Report CS0675 warning for compound assignment operator.
Fixes #909.