Bug4434 new #25290
Bug4434 new #25290
Conversation
JieCarolHu
added
the
PR For Personal Review Only
|
Could you proved a better PR title and (optionally) description? It's not clear what I should be reviewing. |
|
Ok, it looks like this PR adds new public APIs to symbols and touches Compilers. I would like to see a clear description of the problem we are trying to address, an analysis why things don't work, as well as some kind of high level explanation of proposed fix and perhaps other alternatives on the table. |
|
I hadn't noticed that. Thanks @AlekseyTs! @JieCarolHu: adding new public API surface area going requires buy off from the relevant teams and stakeholders. In fact, the |
|
@DustinCampbell @AlekseyTs Thanks for pointing this out. Will do that once this PR is ready for review. Thanks |
Ask Mode template not completed
Customer scenario
What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)
Bugs this fixes
Fixes #4434
Workarounds, if any
Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW
Risk
This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code
Performance impact
(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")
Is this a regression from a previous update?
Root cause analysis
How did we miss it? What tests are we adding to guard against it in the future?
How was the bug found?
(E.g. customer reported it vs. ad hoc testing)
Test documentation updated?
If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.