New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Arcade bootstrapping scripts #30498

Merged
merged 4 commits into from Oct 30, 2018

Conversation

Projects
None yet
3 participants
@tmat
Member

tmat commented Oct 14, 2018

Use Arcade bootstrapping scripts to install dotnet cli.

@tmat tmat requested a review from dotnet/roslyn-infrastructure as a code owner Oct 14, 2018

@tmat tmat changed the title from WIP: Use Arcade bootstrapping scripts to Use Arcade bootstrapping scripts Oct 17, 2018

@tmat

This comment has been minimized.

Member

tmat commented Oct 17, 2018

@jaredpar PTAL

@@ -35,4 +35,23 @@
<Import Project="OptimizationData.targets"/>
<Import Project="SymStore.targets"/>
<UsingTask TaskName="Microsoft.DotNet.Arcade.Sdk.LocateDotNet" AssemblyFile="$(RoslynToolsBuildTasksAssembly)" />
<Target Name="InitializeDotNetToolPath" Condition="'$(DotNetTool)' == ''">

This comment has been minimized.

@jaredpar

jaredpar Oct 18, 2018

Member

Does this mean that VS based builds could pick up the dotnet install that our scripts bootstrap?

This comment has been minimized.

@tmat

tmat Oct 18, 2018

Member

This target makes the DotNetTool variable available in the build no matter how it's triggered (build script, msbuild directly or from VS). The only place I'm aware now that needs this is running tests via msbuild /t:test. We can indeed use this target whenever we need to find dotnet.

This comment has been minimized.

@jaredpar

jaredpar Oct 18, 2018

Member

So is that a yes? Or do we still have to run the .NET SDK MSI before we can build Roslyn?

This comment has been minimized.

@tmat

tmat Oct 18, 2018

Member

The target will fail if it can't find the right version of .NET SDK. It won't try to install it.

Show resolved Hide resolved global.json
@jaredpar

This comment has been minimized.

Member

jaredpar commented Oct 18, 2018

Done with review pass iteration #2

@tmat tmat closed this Oct 29, 2018

@tmat tmat reopened this Oct 29, 2018

@tmat tmat closed this Oct 29, 2018

@tmat tmat reopened this Oct 29, 2018

@tmat

This comment has been minimized.

Member

tmat commented Oct 29, 2018

@jaredpar PTAL. The change now includes msbuild and dotnet SDK version checking.

MSBuildMinimumDisplayVersion="MSBuild 15.7"
/>
<UsingTask TaskName="Microsoft.DotNet.Arcade.Sdk.CompareVersions" AssemblyFile="$(RoslynToolsBuildTasksAssembly)" />
<UsingTask TaskName="Microsoft.DotNet.Arcade.Sdk.SingleError" AssemblyFile="$(RoslynToolsBuildTasksAssembly)" />

This comment has been minimized.

@nguerrera

nguerrera Oct 30, 2018

Member

Why are things in Arcade with AssemblyFile == $(RoslynToolsBuildTasksAssembly)?

This comment has been minimized.

@tmat

tmat Oct 30, 2018

Member

Temporary hack.

This comment has been minimized.

@tmat

tmat Oct 30, 2018

Member

Will move these to Arcade SDK proper.

@tmat tmat merged commit 00384a0 into dotnet:master Oct 30, 2018

4 checks passed

license/cla All CLA requirements met.
Details
roslyn-CI #20181029.22 succeeded
Details
windows_debug_vs-integration_prtest Build finished.
Details
windows_release_vs-integration_prtest Build finished.
Details

@tmat tmat deleted the tmat:DotNet branch Oct 30, 2018

wachulski added a commit to wachulski/roslyn that referenced this pull request Oct 31, 2018

Merge remote-tracking branch 'origin/master' into fix/27866/else-with…
…out-if-error-message

* origin/master: (1712 commits)
  User-defined operator checks should ignore differences in tuple member names (dotnet#30774)
  Attempted fix for correctly reporting error CS1069 when using implicit namespaces (dotnet#30244)
  Invert the binding order of InitializerExpressions and CreationExpressions (dotnet#30805)
  Use Arcade bootstrapping scripts (dotnet#30498)
  Ensure that the compilers produce double.NaN values in IEEE canonical form. (dotnet#30587)
  Remove properties set in BeforeCommonTargets.targets
  Fix publishing of dependent projects
  Contributing page: reference Unix build instructions
  Delete 0
  Propagate values from AbstractProject to VisualStudioProjectCreationInfo
  Fix publishing nuget info of dev16.0.x-vs-deps branch
  Revert "Add a SetProperty API for CPS to passing msbuild properties"
  Validate generic arguments in `using static` directives (dotnet#30737)
  Correct 15.9 publish data
  Enable test.
  Do not inject attribute types into .Net modules.
  Add a SetProperty API for CPS to passing msbuild properties
  Revert "add beta2 suffix to dev16 branch"
  Fix references
  Remove commit sha from package versions
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment