Remove unused diagnostic methods. #30539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Oct 16, 2018
| @@ -108,49 +108,8 @@ public bool IsDiagnosticSuppressed(Diagnostic diagnostic, out AttributeData supp | |||
| return false; | |||
| } | |||
|
|
|||
| private bool IsDiagnosticSuppressed(Diagnostic diagnostic, out SuppressMessageInfo info, ISymbol symbolOpt = null) | |||
There was a problem hiding this comment.
there are no callers of this method that pass in "symbolOpt". So symbolOpt is always null. So nothing ever called IsDiagnosticSuppressed(diagnostic.Id, symbolOpt, out info).
CyrusNajmabadi
commented
Oct 16, 2018
| return parent != null && IsDiagnosticSuppressed(id, parent, out info); | ||
| } | ||
| private bool IsDiagnosticSuppressed(Diagnostic diagnostic, out SuppressMessageInfo info) | ||
| => IsDiagnosticSuppressed(diagnostic.Id, diagnostic.Location, out info); |
There was a problem hiding this comment.
this is just the original method, with the optional symbol (that was never used) removed.
|
Tagging @jcouv |
cston
approved these changes
Oct 16, 2018
gafter
approved these changes
Oct 16, 2018
|
test windows_debug_spanish_unit32_prtest please |
|
Thanks! |
sharwell
pushed a commit
that referenced
this pull request
Oct 29, 2018
…rop-refactoring-naming-alignment * origin/master: (1888 commits) Remove unused diagnostic methods. (#30539) Added missing underscores in resource name (#30545) Move Spanish job to Azure DevOps Add when clause case to the TypeInferrer Add unit test Workaround for missing ZipDirectory task in msbuild 15.7 Build Roslyn_Preview.zip from a project Fixed typo ‘should descent’ Test loading of analyzer built against netstandard1.3 Add links to workitems/test plans (#30476) Use the IsAccessor extension for ISymbol Add unit test Update test. Simplify. Don't double massage actions. Only look at the nested actions, ensuring that this form doesn't change unexpectedly. Set getInnermostNodeForTie argument to true Fix for UseLocalFunction breaking semantics Rename Update name. ... # Conflicts: # src/Features/Core/Portable/InitializeParameter/AbstractInitializeMemberFromParameterCodeRefactoringProviderMemberCreation.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.