Add bunch of exclusions to dead code analysis for special methods #31036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#30886: Bail oun special serialization constructors and methods with certain special attributes indicating special usage. Fixes dotnet#30887: Bail out on ShouldSerializeXXX and ResetXXX pattern that was also excluded from legacy FxCop implementation and seems to be common in real world code. Fixes dotnet#30377 : Bail out on methods with signature matching event handlers, which are very common in Web apps.
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
Show resolved
Hide resolved
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
Show resolved
Hide resolved
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Shared/Extensions/IMethodSymbolExtensions.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Shared/Extensions/ISymbolExtensions.cs
Outdated
Show resolved
Hide resolved
|
Ping @dotnet/roslyn-ide for reviews. |
JoeRobich
approved these changes
Nov 8, 2018
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Nov 8, 2018
|
@jinujoseph for approval |
This was referenced Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30886: Bail out on special serialization constructors and methods with certain special attributes indicating special usage.
Fixes #30887: Bail out on ShouldSerializeXXX and ResetXXX pattern that was also excluded from legacy FxCop implementation and seems to be common in real world code.
Fixes #30377 : Bail out on methods with signature matching event handlers, which are very common in Web apps.