use cleaner syntax for C# Generated.cs files

[Meir017]

summary of changes:

• use lambda-expression for one-line methods

[Meir017]

@jcouv continuation of #31914 #Closed

[jcouv]

using Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax;

I think we have a guideline to have all usings outside the namespace.

If there is a conflict between the usings, then it may be necessary to split the file. Let's hold off on that until things are reviewed in current state though. #Closed

---

Refers to: src/Compilers/CSharp/Test/Syntax/Generated/Syntax.Test.xml.Generated.cs:8 in 0dfbd1e. [](commit_id = 0dfbd1e, deletion_comment = False)

[jcouv]

LGTM with open question about usings inside namespaces. Thanks

[Meir017]

@jcouv any update on this? #Closed

[jaredpar]

@Meir017

I'm not sure about @jcouv but I was waiting for a response to this piece of feedback:

I think we have a guideline to have all usings outside the namespace.

The preference in our repository is using outside the namespace declaration. This PR changes that. #Closed

[Meir017]

So I should generate two files? One for the internal syntax and one for the public #Closed

[jcouv]

So I should generate two files?

You can either revert to use fully-qualified names, or split the file. Thanks #Closed

[CyrusNajmabadi]

So I should generate two files? One for the internal syntax and one for the public

Why can't you just place the usings outside the namespace? #Closed

[jcouv]

Why can't you just place the usings outside the namespace?

I expect this results in ambiguities between public and internal syntax nodes. But if there is a way to make that work, that'd be fine too. #Closed

[Meir017]

@jcouv Done! #Closed

[alrz]

Looks like indentation is different from place to place? (2 spaces vs 4) #Closed

[Meir017]

hmm, looks like there are many name conflicts between the internal namespace and the public one.
for now, I'll just shorten the syntax without splitting into 2 files #Closed

[Meir017]

OK, now it's ready for review #Closed

[jcouv]

internal override GreenNode SetDiagnostics(DiagnosticInfo[] diagnostics) => new OmittedTypeArgumentSyntax(this.Kind, this.omittedTypeArgumentToken, diagnostics, GetAnnotations());

nit: consider breaking fat arrows to the next line with an indent (as you did in the generated Test file), at least for long expressions.

---

Refers to: src/Compilers/CSharp/Portable/Generated/Syntax.xml.Internal.Generated.cs:1572 in c994637. [](commit_id = c994637, deletion_comment = False)

[jcouv]

LGTM Thanks (iteration 15)

[jcouv]

Note: I've recently changed the code generator in master. I'd recommend that you rebase (so we can cleanly squash the PR once ready to merge), but you can merge if you prefer (then we'll just have to merge the PR instead of squashing it).

[jcouv]

Thanks. @dotnet/roslyn-compiler for a second review of this community PR.

[jcouv]

Thanks. @dotnet/roslyn-compiler for a second review of this community PR.

[333fred]

LGTM (commit 16)

[Meir017]

@333fred Just merged from master to resolve the conflicts and then ran the generators again to fix the generated code

[jcouv]

Thanks @Meir017!