Restore fluent call depth #33907
Merged
Restore fluent call depth #33907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
reviewed
Mar 6, 2019
| @@ -33,7 +33,7 @@ public void OverflowOnFluentCall() | |||
| numberFluentCalls = 460; | |||
| break; | |||
| case 32 when !isDebug: | |||
| numberFluentCalls = 1000; | |||
| numberFluentCalls = 1300; | |||
There was a problem hiding this comment.
1300 [](start = 40, length = 4)
nit: I think it will be possible to restore this to 1350 (and bump all other values by 50 as well). That would close #25606
There was a problem hiding this comment.
Locally at least I can do that. Will see if it holds up in CI.
There was a problem hiding this comment.
You could restore the other values as well (+50) to close the linked issue. Thanks
In reply to: 263190688 [](ancestors = 263190688)
There was a problem hiding this comment.
It's in the commit where the change was done. I put it there in case I had to revert that part of the change to get the PR through.
jaredpar
force-pushed
the
fix-fluent
branch
2 times, most recently
from
85de151
to
a8d9e39
Compare
The change to move nullable to a two state solution inadverntently changed how the CLR inlines a number of method calls. The combination of not-inlining and over-inlining caused us to have a much larger "frame" for analyzing a fluent call and exceeded our tolerance levels. This adjusts the inlining so that we get the same results as before. closes dotnet#33775
|
@dotnet/roslyn-compiler for review. |
cston
approved these changes
Mar 7, 2019
prochan2
added a commit
to postsharp/Metalama.Compiler
that referenced
this pull request
Oct 17, 2023
prochan2
added a commit
to postsharp/Metalama.Compiler
that referenced
this pull request
Oct 17, 2023
prochan2
added a commit
to postsharp/Metalama.Compiler
that referenced
this pull request
Oct 18, 2023
…erride dotnet#33907 Environment variable to customize the location of Metalama temp directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to move nullable to a two state solution inadverntently
changed how the CLR inlines a number of method calls. The combination of
not-inlining and over-inlining caused us to have a much larger "frame"
for analyzing a fluent call and exceeded our tolerance levels.
This adjusts the inlining so that we get the same results as before.
closes #33775