Editing tests for support nullable in ENC #36770
Conversation
ivanbasov
added
Interactive-EnC
New Language Feature - Nullable Reference Types
| } | ||
|
|
||
| [Fact] | ||
| public void ChangeArrayOfNullableToArrayOfNonNullable() |
There was a problem hiding this comment.
ChangeArrayOfNullableToArrayOfNonNullable [](start = 20, length = 41)
The foreach tests do not test anything interesting as they are written. We already tested changing the type of a local variable definition above.
What would be interesting to test in foreach loop is when the active statement is inside the loop (e.g. in {) and the type of arr is changed at that point (either explicitly or implicitly via non-nullable inference). We also don't need to test all combinations of nullable to non-nullable in that case. One is enough.
#Resolved
There was a problem hiding this comment.
It would be better to add such foreach tests to the ForEach Statement section since foreach is the major feature EnC-wise and nullability is just one of the ways the type of the iterator may change.
In reply to: 301274368 [](ancestors = 301274368)
| edits.VerifySemanticDiagnostics( | ||
| // (9,25): error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. | ||
| // static void M(string? x) | ||
| Diagnostic(ErrorCode.ERR_FeatureInPreview, "?").WithArguments("nullable reference types").WithLocation(9, 25)); |
There was a problem hiding this comment.
What's the point of checking the error? You should set the test up so that the error is not reported. #Resolved
There was a problem hiding this comment.
| #endregion | ||
| #endregion | ||
|
|
||
| #region Nullables |
There was a problem hiding this comment.
#region Nullables [](start = 7, length = 18)
These tests are not particularly useful here. What part of the EnC logic are they testing?
They would rather be useful in compilers where we test local slot and lambda mapping - see e.g. ComplexTypes test in LocalSlotMappingTests, MethodWithClosure1 in EditAndContinueClosureTests, EditAndContinueStateMachineTests for await/iterator testing etc. #Resolved
There was a problem hiding this comment.
Removed. Will send a separate PR with compiles tests.
In reply to: 301287623 [](ancestors = 301287623)
No description provided.