Remove AttributeTargets.Module from NullableContextAttribute #37610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cston
added
Area-Compilers
New Language Feature - Nullable Reference Types
|
/cc @rynowak |
|
@dotnet/roslyn-compiler, please review minor changes to the metadata spec-let and the synthesized attribute definition to match the implementation. |
RikkiGibson
approved these changes
Jul 31, 2019
agocke
approved these changes
Jul 31, 2019
roji
added a commit
to dotnet/efcore
that referenced
this pull request
Jul 31, 2019
As per dotnet/roslyn#37610, the compiler will no longer emit nullability context attributes at the module level, only at the type and method level. Simplify our non-nullability detection convention. Part of #16440
roji
added a commit
to roji/efcore
that referenced
this pull request
Aug 1, 2019
As per dotnet/roslyn#37610, the compiler will no longer emit nullability context attributes at the module level, only at the type and method level. Simplify our non-nullability detection convention. Part of dotnet#16440
roji
added a commit
to roji/roslyn
that referenced
this pull request
Aug 6, 2019
roji
added a commit
to dotnet/efcore
that referenced
this pull request
Aug 6, 2019
As per dotnet/roslyn#37610, the compiler will no longer emit nullability context attributes at the module level, only at the type and method level. Simplify our non-nullability detection convention. Part of #16440
roji
added a commit
to dotnet/efcore
that referenced
this pull request
Aug 7, 2019
As per dotnet/roslyn#37610, the compiler will no longer emit nullability context attributes at the module level, only at the type and method level. Simplify our non-nullability detection convention. Part of #16440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C# compiler does not support module-level
NullableContextAttribute. This change updates the spec-let and theAttributeTargetson the embedded attribute definition to reflect that.