Reject pattern-matching operations on pointer types in C# versions less than 8. #38116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
Area-Compilers
Tenet-Compatibility
jcouv
reviewed
Aug 20, 2019
| else if (inputType.IsPointerType() == true && Compilation.LanguageVersion < MessageID.IDS_FeatureRecursivePatterns.RequiredVersion()) | ||
| { | ||
| // before C# 8 we did not permit `pointer is null` | ||
| diagnostics.Add(ErrorCode.ERR_PointerTypeInPatternMatching, patternExpression.Location); |
There was a problem hiding this comment.
ERR_PointerTypeInPatternMatching [](start = 46, length = 32)
nit: Would it be better to use ERR_FeatureNotAvailableInVersion8 with an existing feature name (IDS_FeatureRecursivePatterns maybe)? Either way is a bit confusing to users, but we would at least hint towards language version being a fix.
…ss than 8. This fix intentionally does not introduce a "language version" diagnostic because I would like this fix to be as simple as possible to hot-fix 16.3, and because we are past translation deadlines. Fixes dotnet#38052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix intentionally does not introduce a "language version" diagnostic because I would
like this fix to be as simple as possible to hot-fix 16.3, and because we are past translation
deadlines.
Fixes #38052