Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not offer to convert switches when ref-returns are involved. #40236

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Do not offer to convert switches when ref-returns are involved. #40236

merged 3 commits into from
Dec 11, 2019

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #40198

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 7, 2019 23:01
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Dec 7, 2019 •
edited

Tagging @dotnet/roslyn-ide @alrz @mavasani

@CyrusNajmabadi
Copy link
Member Author

Actually though, using 'ref' inside the conditional is fine if you're not using the outer-ref. Will update.

@alrz
Copy link
Contributor

alrz commented Dec 8, 2019

We probably need to update IfToSwitch to handle ref returns in switch expressions.

@CyrusNajmabadi
Copy link
Member Author

We probably need to update IfToSwitch to handle ref returns in switch expressions.

I'll see if i can find that! if not, maybe you can contribute to this PR? Thanks!

@CyrusNajmabadi
Copy link
Member Author

I'll see if i can find that! if not, maybe you can contribute to this PR? Thanks!

Actually, i think i may not have time for this. If you want to add to this PR that would be fine!

@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Dec 8, 2019
@jinujoseph jinujoseph added this to InQueue in IDE: CommunityPR via automation Dec 8, 2019
@jinujoseph jinujoseph moved this from InQueue to BuddyAssigned in IDE: CommunityPR Dec 8, 2019
@CyrusNajmabadi
Copy link
Member Author

@mavasani LMK what you need here to proceed.

IDE: CommunityPR automation moved this from BuddyAssigned to LGTM Dec 11, 2019
@mavasani mavasani merged commit 6bdee08 into dotnet:master Dec 11, 2019
IDE: CommunityPR automation moved this from LGTM to Completed Dec 11, 2019
@CyrusNajmabadi
Copy link
Member Author

Thanks!

@CyrusNajmabadi CyrusNajmabadi deleted the convertSwitchRef branch January 25, 2020 00:47
@alrz alrz mentioned this pull request Mar 13, 2020
Closed
This was referenced Mar 28, 2020
Open
Open
@jinujoseph jinujoseph moved this from Completed-163 to Completed 2020 in IDE: CommunityPR Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alrz alrz alrz approved these changes

@mavasani mavasani mavasani approved these changes

Assignees

@mavasani mavasani

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
IDE: CommunityPR
  
Completed 2020
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE0066 suggests to refactor ref returns
4 participants
@CyrusNajmabadi @alrz @mavasani @jinujoseph