Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a first chance exception in documentation comments #42514

Merged
1 commit merged into from Mar 18, 2020
Merged

Avoid a first chance exception in documentation comments #42514

1 commit merged into from Mar 18, 2020

Conversation

sharwell
Copy link
Member

Fixes #38779

@sharwell sharwell requested a review from a team as a code owner March 17, 2020 23:00
CyrusNajmabadi
CyrusNajmabadi approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes thank you. This has been bugging me a lot :)

jasonmalinowski
jasonmalinowski approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

ghost
ghost approved these changes Mar 18, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 5c5ae58 into dotnet:master Mar 18, 2020
@jinujoseph jinujoseph added this to the Next milestone Mar 18, 2020
@sharwell sharwell modified the milestones: Next, temp, 16.6.P3 Apr 6, 2020
@sharwell sharwell deleted the avoid-fce branch July 2, 2020 19:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
16.6.P3
Development

Successfully merging this pull request may close these issues.

Avoid throw an first chance XmlException in ISymbolExtensions.GetDocumentationComment() when xmlText is empty?
4 participants
@sharwell @jasonmalinowski @CyrusNajmabadi @jinujoseph