Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Inline Temporary support for top-level statements #44421

Merged
merged 1 commit into from
May 20, 2020
Merged

Implement Inline Temporary support for top-level statements #44421

merged 1 commit into from
May 20, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented May 20, 2020 •
edited
Loading

Fixes #44263

馃摑 Some of the results are suboptimal due to #44420

@sharwell sharwell requested a review from a team as a code owner May 20, 2020 15:49
CyrusNajmabadi
CyrusNajmabadi reviewed May 20, 2020
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems fine. But I worry that global statements will trip up all existing fixers. Should we potentially fix up removenode to remove the global statement of called on the statement within?

@sharwell sharwell merged commit 0b043dd into dotnet:features/SimplePrograms May 20, 2020
@sharwell sharwell deleted the inline-temp branch May 20, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
New Language Feature - Simple Programs Top-level statements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sharwell @CyrusNajmabadi @AlekseyTs