Revert "Merge pull request #47914 from CyrusNajmabadi/lspDiagnostics" #48228

dibarbet · 2020-10-01T22:38:03Z

This reverts commit 3911ee0, reversing
changes made to 60ae83d.

This is breaking the nexus test b/c squiggles are not appearing with pull diagnostics. Editor bug here https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1224360

…stics" This reverts commit 3911ee0, reversing changes made to 60ae83d.

ghost · 2020-10-02T03:50:15Z

Hello @dibarbet!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost

Auto-approval

Revert "Merge pull request dotnet#47914 from CyrusNajmabadi/lspDiagno…

02a9e20

…stics" This reverts commit 3911ee0, reversing changes made to 60ae83d.

dibarbet added Area-IDE Area-Infrastructure labels Oct 1, 2020

dibarbet requested a review from CyrusNajmabadi October 1, 2020 22:38

dibarbet requested a review from a team as a code owner October 1, 2020 22:38

dibarbet added the auto-merge label Oct 2, 2020

ghost approved these changes Oct 2, 2020

View reviewed changes

ghost merged commit 98be2b1 into dotnet:master-vs-deps Oct 2, 2020

ghost added this to the Next milestone Oct 2, 2020

dibarbet deleted the revert_pull branch October 2, 2020 03:51

This was referenced Oct 2, 2020

Test failures via timeline in Roslyn jaredpar/runfo#37

Closed

Test failures via timeline in Roslyn jaredpar/runfo#38

Closed

Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Merge pull request #47914 from CyrusNajmabadi/lspDiagnostics" #48228

Revert "Merge pull request #47914 from CyrusNajmabadi/lspDiagnostics" #48228

dibarbet commented Oct 1, 2020

ghost commented Oct 2, 2020

ghost left a comment

Revert "Merge pull request #47914 from CyrusNajmabadi/lspDiagnostics" #48228

Revert "Merge pull request #47914 from CyrusNajmabadi/lspDiagnostics" #48228

Conversation

dibarbet commented Oct 1, 2020

ghost commented Oct 2, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost left a comment

Choose a reason for hiding this comment

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.