Handle substring in string itself in IDE0057 #48321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (invocation.Expression is IdentifierNameSyntax) | ||
| { | ||
| // Substring(...) -> this[...] | ||
| return ElementAccessExpression(ThisExpression(), argumentList); |
There was a problem hiding this comment.
i'd prefer we also validate that we're inside the string class. Or, if htis is handling more than just being inside System.String and is handling things like .Slice inside other types, then we can have a simpler test that just shows that.
There was a problem hiding this comment.
I'd prefer the latter, adding a test for slicing on self.
jinujoseph
added
Area-IDE
Community
|
This one should be simple enough. Not sure what the CI failure is. |
CyrusNajmabadi
approved these changes
Nov 2, 2020
ghost
added this to the 
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38055