Make each request id for doc and workspace diagnostics unique. #49343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Nov 13, 2020
| // getting document diagnostics should not ask for workspace diagnostics with the result-ids it got for | ||
| // doc-diagnostics. The two systems are different and cannot share results, or do things like report | ||
| // what changed between each other. | ||
| var resultId = $"{GetType().Name}:{_nextDocumentResultId++}"; |
There was a problem hiding this comment.
Is it worth just initializing a field with GetType().Name, since it won't change?
|
Hello @CyrusNajmabadi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lsp client was calling into one type of diagnostic request with request-ids returned by the other type. This oculd lead to broken or inconsistent results. We now ensure the result ids are different so that this never considered legal.