Format pointers to have asterisk next to type instead of identifier #49875
Conversation
Youssef1313
changed the title
| if (currentToken.Kind() == SyntaxKind.AsteriskToken && currentToken.Parent is PointerTypeSyntax) | ||
| { | ||
| return CreateAdjustSpacesOperation(1, AdjustSpacesOption.ForceSpacesIfOnSingleLine); | ||
| } | ||
|
|
||
| if (previousToken.Kind() == SyntaxKind.AsteriskToken && | ||
| (previousToken.Parent is PrefixUnaryExpressionSyntax || previousToken.Kind() == SyntaxKind.IdentifierToken)) |
There was a problem hiding this comment.
NOTE: The original issue complains about NormalizeWhitespace, I'm not sure whether this affects NormalizeWhitespace or not.
|
The number of failing tests is large. So I'd like to have a review on the code change before fixing the tests. |
| (previousToken.Kind() == SyntaxKind.AsteriskToken && previousToken.Parent is PrefixUnaryExpressionSyntax)) | ||
| if (currentToken.Kind() == SyntaxKind.AsteriskToken && currentToken.Parent is PointerTypeSyntax) | ||
| { | ||
| return CreateAdjustSpacesOperation(1, AdjustSpacesOption.ForceSpacesIfOnSingleLine); |
There was a problem hiding this comment.
❗ I believe this will break the formatter for types like int** (it will start to format them as int* *.
There was a problem hiding this comment.
@sharwell Do we want to fix both the formatter and NormalizeWhitespace? or only NormalizeWhitespace?
There was a problem hiding this comment.
shouldn't we always adjust this to 0 spaces if we have the * of a pointer type? i would think we would always want zero spaces between that and whatever comes before it
There was a problem hiding this comment.
@CyrusNajmabadi Whops, I mixed things up. Swapped the expected behavior and the actual behavior.
The formatter behaves as expected. This is only a NormalizeWhitespace issue.
Closing the PR.
jinujoseph
added
the
Community
Fixes #49733