Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString
#52061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oundUnconvertedInterpolatedString` This is intended to be a semantics-preserving refactoring that will make later work easier. When an interpolated string is first encountered, we now bind it as a `BoundUnconvertedInterpolatedString` node, and then when we bind to the natural type we convert it to a `BoundInterpolatedString` expression. Future code to allow it to convert to non-string types will take advantage of this in the conversion step.
|
@chsienki for review. |
chsienki
reviewed
Mar 24, 2021
AlekseyTs
reviewed
Mar 25, 2021
chsienki
reviewed
Mar 25, 2021
chsienki
approved these changes
Mar 25, 2021
AlekseyTs
reviewed
Mar 25, 2021
src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/ConversionsBase.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Mar 25, 2021
AlekseyTs
reviewed
Mar 25, 2021
|
Done with review pass (commit 1) #Closed |
|
@AlekseyTs addressed feedback. In reply to: 807471528 [](ancestors = 807471528) |
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 25, 2021
* upstream/main: (75 commits) Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString (dotnet#52061) Combine VB comparers into one, and combine VB and C# comparers together (dotnet#51834) Use OptimizedVSCompletionList in LSP scenarios. F5 Hot Reload (dotnet#52101) Fix typescript shim Add tests for lazy syntax trees coming from the GeneratorDriver React to code review feedback. Simplify the lazy-initalization pattern used in GetRoot Remove an unnecessary override. (dotnet#52140) Update issue number (dotnet#52130) Enable CodeActions support for XAML using its own provider and CodeActionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129) Add RestrictedIVT to dotnet watch to Features (dotnet#52087) Don't try to highlight operators (dotnet#52041) Use `null` instead of empty signature helps in LSP Use member type for relational pattern even in error cases (dotnet#51950) Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Extensions/SymbolExtensions.cs Use new QuickInfoUtilities helper Rebuild API shape (dotnet#52079) Added position parameter name Updated XAML QuickInfo to show more info like C# by using ISymbolDisplayService and adding more documentation parts. ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be a semantics-preserving refactoring that will make later work easier. When an interpolated string is first encountered, we now bind it as a
BoundUnconvertedInterpolatedStringnode, and then when we bind to the natural type we convert it to aBoundInterpolatedStringexpression. Future code to allow it to convert to non-string types will take advantage of this in the conversion step.