Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main #52156

Merged
92 commits merged into from Mar 26, 2021
Merged

merge main #52156

92 commits merged into from Mar 26, 2021

Conversation

333fred
Copy link
Member

@333fred 333fred commented Mar 25, 2021

sharwell and others added 30 commits December 30, 2020 09:24
- Don't take a cancellation token, since the whole point is not to
  do expensive work
- Just keep fields and parameters in a consistent order
mgoertz-msft and others added 23 commits March 24, 2021 10:26
…sions/SymbolExtensions.cs

Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
Add intellicode API for generating code action edits from intents and
- The LSP specification requires that `signatures` be provided. Currently Roslyn breaks this LSP contract by returning a new signature help item. It should be returning `null`
…tionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129)

Switch to using a path to DocumentId cache in the XamlProjectService to avoid unnecessary and sometimes dangerous transitions to the main thread during TrackDocument calls.
Update IDEDiagnosticIDConfigurationTests to be exclusive rather than inclusive
* Move debugging service to debugging session

* Remove warnings for edits made while app is running

* Open edit sessions for both running and break states

* Trigger document reanalysis after EmitSolutionUpdateAsync
- The optimized completion list type offers "fast" serialization (3.7x).
- This is dependent upon a VS LSP Platform PR getting in: https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/312367
- Update language server protocol package version.

Part of dotnet/aspnetcore#30232
Use `null` instead of empty signature helps in LSP
Replace SyntaxTree caching with IDE document state preservation
…nconvertedInterpolatedString (dotnet#52061)

This is intended to be a semantics-preserving refactoring that will make later work easier. When an interpolated string is first encountered, we now bind it as a `BoundUnconvertedInterpolatedString` node, and then when we bind to the natural type we convert it to a `BoundInterpolatedString` expression. Future code to allow it to convert to non-string types will take advantage of this in the conversion step.
* upstream/main: (75 commits)
  Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString (dotnet#52061)
  Combine VB comparers into one, and combine VB and C# comparers together (dotnet#51834)
  Use OptimizedVSCompletionList in LSP scenarios.
  F5 Hot Reload (dotnet#52101)
  Fix typescript shim
  Add tests for lazy syntax trees coming from the GeneratorDriver
  React to code review feedback.
  Simplify the lazy-initalization pattern used in GetRoot
  Remove an unnecessary override. (dotnet#52140)
  Update issue number (dotnet#52130)
  Enable CodeActions support for XAML using its own provider and CodeActionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129)
  Add RestrictedIVT to dotnet watch to Features (dotnet#52087)
  Don't try to highlight operators (dotnet#52041)
  Use `null` instead of empty signature helps in LSP
  Use member type for relational pattern even in error cases (dotnet#51950)
  Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Extensions/SymbolExtensions.cs
  Use new QuickInfoUtilities helper
  Rebuild API shape (dotnet#52079)
  Added position parameter name
  Updated XAML QuickInfo to show more info like C# by using ISymbolDisplayService and adding more documentation parts.
  ...
@333fred 333fred requested review from a team as code owners March 25, 2021 23:27
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 8623b91 into dotnet:features/interpolated-string Mar 26, 2021
@333fred 333fred deleted the merge-main branch March 26, 2021 03:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet