Avoid generating Document instances in cases where we only need a documentId in the work coordinator. #53817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jun 1, 2021
|
|
||
| await _processor.EnqueueWorkItemAsync(document).ConfigureAwait(false); | ||
| await _processor.EnqueueWorkItemAsync(document.Project, document.Id, document).ConfigureAwait(false); |
There was a problem hiding this comment.
if we were in a scenario where we actually had the document, then we pass it along to avoid extra work later.
There was a problem hiding this comment.
we could consdier not passing hte doc with the hope that project.GetDocument(id) is cheap if the red doc was already created.
sharwell
reviewed
Jun 1, 2021
src/Features/Core/Portable/SolutionCrawler/WorkCoordinator.SemanticChangeProcessor.cs
Outdated
Show resolved
Hide resolved
|
|
||
| await _processor.EnqueueWorkItemAsync(document).ConfigureAwait(false); | ||
| await _processor.EnqueueWorkItemAsync(solution.GetRequiredProject(documentId.ProjectId), documentId, document: null).ConfigureAwait(false); |
There was a problem hiding this comment.
Do we want to have some comment here that we're trying to avoid grabbing the Document? I can imagine somebody else coming back to this and wondering why it wasn't written the original way.
jasonmalinowski
approved these changes
Jun 3, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53816