Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Diagnostics TaggerDelay #56354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akhera99
Copy link
Member

@akhera99 akhera99 commented Sep 13, 2021

Here are two videos with differing TaggerDelays to make it so the diagnostics do not feel as obstructive.
Please let me know which one you find more appealing 馃憤

Medium Delay:

ConsoleApp7.-.Microsoft.Visual.Studio.Preview.2021-09-13.11-56-29.mp4

OnIdle Delay

ConsoleApp7.-.Microsoft.Visual.Studio.Preview.2021-09-13.11-59-36_Trim.mp4

@mikadumont

@CyrusNajmabadi
Copy link
Member

So the videos don't really reflect the scenario we care about here. They show the experience around editing+waiting and seeing how long it takes. The scenario that matters is that during normal coding, with constant typing/navigation/features that these items don't appear too flashy.

That said, squiggles on OnIdle i believe, so i would fully expect these squiggles to be OnIdle as the fatest we would ever make them. They should not be faster than squiggles themselves.

@akhera99
Copy link
Member Author

So the videos don't really reflect the scenario we care about here. They show the experience around editing+waiting and seeing how long it takes. The scenario that matters is that during normal coding, with constant typing/navigation/features that these items don't appear too flashy.

That said, squiggles on OnIdle i believe, so i would fully expect these squiggles to be OnIdle as the fatest we would ever make them. They should not be faster than squiggles themselves.

Squiggles are on Short, I can create new videos. I was trying to show the disparity of time it takes for items to get removed/added.

@CyrusNajmabadi
Copy link
Member

hrm... something in the squiggle pipeline thought shoudl be adding the 1.5 second delay we expect to not make it too flashy.

@akhera99
Copy link
Member Author

Medium:

Medium.mp4

OnIdle:

OnIdle.mp4

@Cosifne Cosifne changed the base branch from release/dev17.1-preview1 to main September 28, 2021 04:56
@Cosifne
Copy link
Member

Cosifne commented Sep 28, 2021

Retarget this to main because 17.1 branch is not used and main is 17.1 now

Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "On Idle" is the right choice here. There is no reason I would want these to be present during typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants