Add support for adding null checks to records. #59404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Feb 9, 2022
| @@ -29,18 +29,27 @@ internal abstract partial class AbstractInitializeParameterCodeRefactoringProvid | |||
| where TStatementSyntax : SyntaxNode | |||
| where TExpressionSyntax : SyntaxNode | |||
| { | |||
| private readonly Func<SyntaxNode, bool> _isFunctionDeclarationFunc; | |||
| protected readonly Func<SyntaxNode, bool> _isFunctionDeclarationFunc; | |||
| protected readonly Func<SyntaxNode, bool> _isRecordDeclarationFunc; | |||
There was a problem hiding this comment.
With the compiler change about caching method groups, do we need to bother with the protected fields any more, versus just referencing the methods directly?
There was a problem hiding this comment.
This is not a static method, so we'd still need this manual caching
ghost
added this to the 
RikkiGibson
reviewed
Feb 9, 2022
| protected override ISyntaxFacts SyntaxFacts | ||
| => CSharpSyntaxFacts.Instance; | ||
|
|
||
| protected override bool SupportsRecords(ParseOptions options) |
There was a problem hiding this comment.
I didn't understand this bit. It seems like a primary constructor parameter is perfectly valid to use to initialize a member. It just has to be in a field initializer. Maybe the refactoring isn't intended for that scenario?
record Rec(int X)
{
public int X; // can offer `= X;` refactoring here?
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58779