Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash with type parameter on type constrained to file-local type #62448

Merged
merged 5 commits into from
Jul 8, 2022
Merged

Fix crash with type parameter on type constrained to file-local type #62448

merged 5 commits into from
Jul 8, 2022

Conversation

RikkiGibson
Copy link
Contributor

Related to #60819
Fixes #62435

@RikkiGibson RikkiGibson requested a review from a team as a code owner July 6, 2022 23:15
jcouv
jcouv reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 1)

@jcouv jcouv self-assigned this Jul 7, 2022
@RikkiGibson RikkiGibson requested a review from jcouv July 7, 2022 18:03
jcouv
jcouv approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3), but I wonder if we can make the code more readable

@runfoapp runfoapp bot mentioned this pull request Jul 7, 2022
Open
jcouv
jcouv approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 5)

@RikkiGibson RikkiGibson enabled auto-merge (squash) July 8, 2022 16:39
@RikkiGibson RikkiGibson merged commit e95f5fb into dotnet:main Jul 8, 2022
@ghost ghost added this to the Next milestone Jul 8, 2022
@RikkiGibson RikkiGibson deleted the fix-62435 branch July 8, 2022 18:15
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
@ryzngard ryzngard mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@cston cston cston approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
17.4 P1
Development

Successfully merging this pull request may close these issues.

Specifying file class as generic constraints crashes the compiler with NRE
5 participants
@RikkiGibson @CyrusNajmabadi @cston @jcouv @allisonchou