Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.3 to main #62573

Merged
merged 13 commits into from
Jul 20, 2022
Merged

Merge release/dev17.3 to main #62573

merged 13 commits into from
Jul 20, 2022

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev17.3 into main.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.3-to-main
git reset --hard upstream/main
git merge upstream/release/dev17.3
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.3-to-main --force

@dotnet-bot dotnet-bot requested review from a team as code owners July 12, 2022 21:01
@dotnet-bot dotnet-bot force-pushed the merges/release/dev17.3-to-main branch from 9d14c64 to be8eed3 Compare July 12, 2022 21:01
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Jul 12, 2022
@dotnet-bot
Copy link
Collaborator Author

⚠ This PR has merge conflicts. @allisonchou

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@JoeRobich JoeRobich removed the Merge Conflicts There are merge conflicts with the base branch. label Jul 12, 2022
…e-43b78dc31d3b

Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1875846
@JoeRobich JoeRobich force-pushed the merges/release/dev17.3-to-main branch from 43cbcca to e308b4a Compare July 13, 2022 21:25
@JoeRobich JoeRobich force-pushed the merges/release/dev17.3-to-main branch from 2034a52 to e340ba5 Compare July 15, 2022 00:25
@JoeRobich
Copy link
Member

@RikkiGibson Looks like VB ErrorFacts doesn't know how to respond to ERRID.WRN_AnalyzerReferencesNewerCompiler. Can you assist?

@allisonchou
Copy link
Contributor

@RikkiGibson it looks like the tests are still failing - would you have any context?

@RikkiGibson
Copy link
Contributor

looks like C# needs the same change.

@RikkiGibson
Copy link
Contributor

@allisonchou let me know if you'd like assistance merging here.

@allisonchou allisonchou merged commit a3c05ab into main Jul 20, 2022
@allisonchou allisonchou deleted the merges/release/dev17.3-to-main branch July 20, 2022 22:09
@ghost ghost added this to the Next milestone Jul 20, 2022
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 20, 2022
* upstream/main: (66 commits)
  Merge release/dev17.3 to main (dotnet#62573)
  Fix
  Find the right symbol when following type forwards (dotnet#62406)
  Remove unused parameter (dotnet#62685)
  Fix NRE in nullable walker (dotnet#62773)
  Delete obsolete internal options (dotnet#62746)
  Optimize away unchecked conversions between nint and nuint types. (dotnet#62774)
  Delete
  Inline members
  Clean up global options usage in tests (dotnet#62692)
  Update dependencies from https://github.com/dotnet/source-build-externals build 20220719.2 (dotnet#62787)
  Update src/Workspaces/Remote/ServiceHub/Services/Renamer/RemoteRenamerService.cs
  No need to roundtrip symbol
  Unused variable
  formatting
  Get document properly
  Lint
  Simplify
  Remove unnecessary callbacks
  Add telemetry
  ...
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants