Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation #62684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rkspaces/SharedUtilitiesAndExtensions/Compiler/Core/Options/ClientSettingsStorageLocation.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 15, 2022
...ces/SharedUtilitiesAndExtensions/Compiler/Core/Options/LocalClientSettingsStorageLocation.cs
Show resolved
Hide resolved
...rkspaces/SharedUtilitiesAndExtensions/Compiler/Core/Options/ClientSettingsStorageLocation.cs
Outdated
Show resolved
Hide resolved
...ces/SharedUtilitiesAndExtensions/Compiler/Core/Options/LocalClientSettingsStorageLocation.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/FormattingOptions2.cs
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Jul 16, 2022
…tion that can be used to access VS Settings storage regardless of whether the option roams or not. Replace LanguageSettingsPersister with LocalClientSettingsStorageLocation (subclass of ClientSettingsStorageLocation that does not roam).
ghost
added this to the 
|
I love the idea that while I was asleep, a PR was created, and merged, that fixes a bug I was assigned to. Thank you :) (and hopefully doesn't break VS Mac 😛) |
allisonchou
added a commit
to allisonchou/roslyn
that referenced
this pull request
Jul 18, 2022
…rageLocation (dotnet#62684)" This reverts commit 51cc7c9.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jul 18, 2022
…tingsStorageLocation (dotnet#62684)"" This reverts commit 9c68f9b.
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 18, 2022
* upstream/main: (40 commits) Revert "Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation (dotnet#62684)" Revert "Update SymReader to the latest version (dotnet#62695)" Apply changes directly to text buffer - take 2 (dotnet#62617) Allow diagnostic tagging to use either push or pull diagnostics Tests test and more tests Fix new rename showing overloads when not applicable (dotnet#62559) Add stronger type safety Add support for resolving contextual error types Pass LineFormatting options into OmniSharpCodeAction options Initial approach to supporting contextual types Update dependencies from https://github.com/dotnet/arcade build 20220715.4 (dotnet#62704) Handle diff3 conflict markers (dotnet#62391) Update SymReader to the latest version (dotnet#62695) Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation (dotnet#62684) Add IWorkspaceProjectContextFactory F# wappers (dotnet#62646) Use OmniSharp LineFormatting fallback options in more places. Remove dependency on Microsoft.VisualStudio.RemoteControl assembly from Features (dotnet#62655) Add array initialization optimization (dotnet#62392) [main] Update dependencies from dotnet/arcade (dotnet#62597) Keep selection on rename invocation (dotnet#62654) ...
adamperlin
pushed a commit
to adamperlin/roslyn
that referenced
this pull request
Jul 19, 2022
…tion (dotnet#62684) Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation that can be used to access VS Settings storage regardless of whether the option roams or not. Replace LanguageSettingsPersister with LocalClientSettingsStorageLocation (subclass of ClientSettingsStorageLocation that does not roam).
adamperlin
pushed a commit
to adamperlin/roslyn
that referenced
this pull request
Jul 19, 2022
…rageLocation (dotnet#62684)" This reverts commit 51cc7c9.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jul 29, 2022
…tingsStorageLocation (dotnet#62684)"" (dotnet#62759) This reverts commit 9c68f9b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation that can be used to access VS Settings storage regardless of whether the option roams or not.
Replace LanguageSettingsPersister with LocalClientSettingsStorageLocation (subclass of ClientSettingsStorageLocation that does not roam).
Manually tested that all settings previously handled by LanguageSettingsPersister still work.
Follow ups:
Fixes #56815
Fixes #43393
Closes #46167 (by virtue of code no longer existing)
Fixes #29602
Fixes AB#1424294