Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All text editor options are roaming #62753

Merged
merged 1 commit into from
Jul 28, 2022
Merged

All text editor options are roaming #62753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EditorFeatures/Core/Options/NavigationBarViewOptionsStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ internal sealed class NavigationBarViewOptionsStorage
private const string FeatureName = "NavigationBarOptions";

public static readonly PerLanguageOption2<bool> ShowNavigationBar = new(
FeatureName, "ShowNavigationBar", defaultValue: true, new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Dropdown Bar"));
FeatureName, "ShowNavigationBar", defaultValue: true, new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Dropdown Bar"));
}
2 changes: 1 addition & 1 deletion src/EditorFeatures/Core/Options/SignatureHelpViewOptionsStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ internal sealed class SignatureHelpViewOptionsStorage
private const string FeatureName = "SignatureHelpOptions";

public static readonly PerLanguageOption2<bool> ShowSignatureHelp = new(
FeatureName, "ShowSignatureHelp", defaultValue: true, new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Auto List Params"));
FeatureName, "ShowSignatureHelp", defaultValue: true, new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Auto List Params"));
}
4 changes: 2 additions & 2 deletions src/Features/LanguageServer/Protocol/Features/Options/CompletionOptionsStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ public static CompletionOptions GetCompletionOptions(this IGlobalOptionService o

public static readonly PerLanguageOption2<bool> HideAdvancedMembers = new(
"CompletionOptions", "HideAdvancedMembers", CompletionOptions.Default.HideAdvancedMembers,
new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Hide Advanced Auto List Members"));
new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Hide Advanced Auto List Members"));

public static readonly PerLanguageOption2<bool> TriggerOnTyping = new(
"CompletionOptions", "TriggerOnTyping", CompletionOptions.Default.TriggerOnTyping,
new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Auto List Members"));
new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Auto List Members"));

public static readonly PerLanguageOption2<bool> TriggerOnTypingLetters = new(nameof(CompletionOptions), nameof(TriggerOnTypingLetters), CompletionOptions.Default.TriggerOnTypingLetters,
storageLocation: new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Specific.TriggerOnTypingLetters"));
Expand Down
6 changes: 3 additions & 3 deletions src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/FormattingOptions2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,19 @@ public Provider()
new(FeatureName, FormattingOptionGroups.IndentationAndSpacing, nameof(UseTabs), LineFormattingOptions.Default.UseTabs,
storageLocations: ImmutableArray.Create<OptionStorageLocation2>(
new EditorConfigStorageLocation<bool>("indent_style", s => s == "tab", isSet => isSet ? "tab" : "space"),
new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Insert Tabs")));
new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Insert Tabs")));

public static PerLanguageOption2<int> TabSize =
new(FeatureName, FormattingOptionGroups.IndentationAndSpacing, nameof(TabSize), LineFormattingOptions.Default.TabSize,
storageLocations: ImmutableArray.Create<OptionStorageLocation2>(
EditorConfigStorageLocation.ForInt32Option("tab_width"),
new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Tab Size")));
new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Tab Size")));

public static PerLanguageOption2<int> IndentationSize =
new(FeatureName, FormattingOptionGroups.IndentationAndSpacing, nameof(IndentationSize), LineFormattingOptions.Default.IndentationSize,
storageLocations: ImmutableArray.Create<OptionStorageLocation2>(
EditorConfigStorageLocation.ForInt32Option("indent_size"),
new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Indent Size")));
new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Indent Size")));

public static PerLanguageOption2<string> NewLine =
new(FeatureName, FormattingOptionGroups.NewLine, nameof(NewLine), LineFormattingOptions.Default.NewLine,
Expand Down