Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AnalyzerOptionsProvider to Analyzers layer #62859

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 22, 2022

The corresponding language-specific types are already in Analyzers layer.

https://github.com/dotnet/roslyn/blob/main/src/Analyzers/CSharp/Analyzers/CodeStyle/CSharpAnalyzerOptionsProvider.cs

So I thought AnalyzerOptionsProvider should be in Analyzers too.

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 22, 2022 06:42
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jul 22, 2022
@Youssef1313
Copy link
Member Author

@mavasani @tmat Can you take a look please? Thanks!

@Youssef1313
Copy link
Member Author

Ping @mavasani @tmat for review.

@mavasani mavasani merged commit 713c3b8 into dotnet:main Jul 25, 2022
@ghost ghost added this to the Next milestone Jul 25, 2022
@Youssef1313 Youssef1313 deleted the move-analyzer-options-provider branch July 25, 2022 10:26
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants