Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async rename prefs string #62867

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Fix async rename prefs string #62867

merged 2 commits into from
Jul 25, 2022

Conversation

sandyarmstrong
Copy link
Member

No description provided.

</root>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for editing in the browser. I can undo this if you want or we can leave it to make updating strings from GitHub easier.

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the build should fail. You need to build locally to get XLF files updated.

@sandyarmstrong
Copy link
Member Author

I believe the build should fail. You need to build locally to get XLF files updated.

OK, I'll leave this to other folks then.

@Youssef1313
Copy link
Member

@sandyarmstrong I updated it in c1fc8d1, let me know if you want to cherry pick it or want me to open a new PR.

@genlu genlu merged commit 3b9d8be into main Jul 25, 2022
@ghost ghost added this to the Next milestone Jul 25, 2022
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
@JoeRobich JoeRobich deleted the dev/sandy/rename-async-pref branch September 3, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants