Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzer info for detecting IntPtr/UintPtr behavioral changes #64485

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Oct 4, 2022

Related to Prevent behavioral change in built-in operators for IntPtr and UIntPtr analyzer

Initially we wanted to warn for potential behavioral changes detected, but after testing the analyzer with runtime and few other repos we decided to degrade the analysis level to info as there were very few cases that could cause a real behavioral change.

As now users will not be warned if their code had a potential behavioral changes we want to inform them that there is an analyzer that they could use for detecting such breaking behavioral changes in this doc (I did not found any other breaking change doc except this one)

CC @jeffhandley @tannergooding

Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording feedback.

Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
@buyaa-n buyaa-n merged commit f36ea16 into dotnet:main Oct 5, 2022
@ghost ghost added this to the Next milestone Oct 5, 2022
@buyaa-n buyaa-n deleted the analyzer_info branch October 5, 2022 00:27
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants