Update version of roslyn-analyzers that Roslyn itself uses #68497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
sharwell
approved these changes
Jun 8, 2023
sharwell
approved these changes
Jun 8, 2023
|
Ugh. Looks like problems exist with this version of the analyzer. Or, rather, it has found more things that can be made static. I'll update accordingly. |
CyrusNajmabadi
commented
Jun 8, 2023
| @@ -318,7 +318,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.AddImport | |||
| Return AddImportAsync(contextNode, document, importsStatement, options, cancellationToken) | |||
| End Function | |||
|
|
|||
| Private Function CreateNameSyntax(nameSpaceParts As IReadOnlyList(Of String), index As Integer) As NameSyntax | |||
| Private Shared Function CreateNameSyntax(nameSpaceParts As IReadOnlyList(Of String), index As Integer) As NameSyntax | |||
There was a problem hiding this comment.
updated anlayzer detects recursive methods that can be made static now. so had to fix up a bunch of new places.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in fix dotnet/roslyn-analyzers#6677.