Fix missing comma classification in json classification #68535
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -187,7 +197,7 @@ public void Visit(JsonTextNode node) | |||
|
|
|||
| public void Visit(JsonCommaValueNode node) | |||
| { | |||
| AddClassification(node.CommaToken, ClassificationTypeNames.JsonPunctuation); | |||
| // already handled when we recurse in AddTokenClassifications | |||
There was a problem hiding this comment.
I don't think I understand how the logic in here works. Why are commas special versus other types of tokens handled by the other visit methods?
There was a problem hiding this comment.
Commas are handled slightly specially in json (for error recovery purposes). They can both be a node (with a token in them), or just a token in separated list. We were only handling the first case.
Now we handle both cases by just checking the token case only.
There was a problem hiding this comment.
Probably worth documenting that :)
There was a problem hiding this comment.
That's what I thought that comment was :'(
There was a problem hiding this comment.
This comment explains a bit of the why, but not the "commas are special for error recovery" part. That's what I needed to know to understand the code 🙂.
ghost
added this to the 
Fixes #68534